Development Flow

Thank you for your time and effort to help us improve Rook! Here are a few steps to get started. If you have any questions, don't hesitate to reach out to us on our Slack dev channel.

Prerequisites¶

1. GO 1.17 or greater installed
2. Git client installed
3. GitHub account

Initial Setup¶

Create a Fork¶

From your browser navigate to http://github.com/rook/rook and click the "Fork" button.

Clone Your Fork¶

Open a console window and do the following;

1
2
3
4
5
6
7
8
9

# Create the rook repo path
mkdir -p $GOPATH/src/github.com/rook

# Navigate to the local repo path and clone your fork
cd $GOPATH/src/github.com/rook

# Clone your fork, where <user> is your GitHub account name
$ git clone https://github.com/<user>/rook.git
cd rook

Build¶

Building Rook Ceph is simple.

1

make

If you want to use podman instead of docker then uninstall docker packages from your machine, make will automatically pick up podman.

Development Settings¶

To provide consistent whitespace and other formatting in your go and other source files (e.g., Markdown), it is recommended you apply the following settings in your IDE:

• Format with the goreturns tool
• Trim trailing whitespace
• Markdown Table of Contents is correctly updated automatically

For example, in VS Code this translates to the following settings:

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11

{
    "editor.formatOnSave": true,
    "go.buildOnSave": "package",
    "go.formatTool": "goreturns",
    "files.trimTrailingWhitespace": true,
    "files.insertFinalNewline": true,
    "files.trimFinalNewlines": true,
    "markdown.extension.toc.unorderedList.marker": "*",
    "markdown.extension.toc.githubCompatibility": true,
    "markdown.extension.toc.levels": "2..2"
}

In addition to that it is recommended to install the following extensions:

• Markdown All in One by Yu Zhang - Visual Studio Marketplace

Add Upstream Remote¶

First you will need to add the upstream remote to your local git:

1
2
3
4
5

# Add 'upstream' to the list of remotes
git remote add upstream https://github.com/rook/rook.git

# Verify the remote was added
git remote -v

Now you should have at least origin and upstream remotes. You can also add other remotes to collaborate with other contributors.

Layout¶

A source code layout is shown below, annotated with comments about the use of each important directory:

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39

rook
├── build                         # build makefiles and logic to build, publish and release all Rook artifacts
├── cluster
│   ├── charts                    # Helm charts
│   │   └── rook-ceph
│   │   └── rook-ceph-cluster
│   └── examples                  # Sample yaml files for Rook cluster
│
├── cmd                           # Binaries with main entrypoint
│   ├── rook                      # Main command entry points for operators and daemons
│
├── design                        # Design documents for the various components of the Rook project
├── Documentation                 # Rook project Documentation
├── images                        # Dockerfiles to build images for all supported storage providers
│
├── pkg
│   ├── apis
│   │   ├── ceph.rook.io          # ceph specific specs for cluster, file, object
│   │   │   ├── v1
│   ├── client                    # auto-generated strongly typed client code to access Rook APIs
│   ├── clusterd
│   ├── daemon                    # daemons for each storage provider
│   │   ├── ceph
│   │   └── discover
│   ├── operator                  # all orchestration logic and custom controllers for each storage provider
│   │   ├── ceph
│   │   ├── discover
│   │   ├── k8sutil
│   │   └── test
│   ├── test
│   ├── util
│   └── version
└── tests                         # integration tests
    ├── framework                 # the Rook testing framework
    │   ├── clients               # test clients used to consume Rook resources during integration tests
    │   ├── installer             # installs Rook and its supported storage providers into integration tests environments
    │   └── utils
    ├── integration               # all test cases that will be invoked during integration testing
    └── scripts                   # scripts for setting up integration and manual testing environments

Development¶

To add a feature or to make a bug fix, you will need to create a branch in your fork and then submit a pull request (PR) from the branch.

Design Document¶

For new features of significant scope and complexity, a design document is recommended before work begins on the implementation. So create a design document if:

• Adding a new CRD
• Adding a significant feature to an existing storage provider. If the design is simple enough to describe in a github issue, you likely don't need a full design doc.

For smaller, straightforward features and bug fixes, there is no need for a design document. Authoring a design document for big features has many advantages:

• Helps flesh out the approach by forcing the author to think critically about the feature and can identify potential issues early on
• Gets agreement amongst the community before code is written that could be wasted effort in the wrong direction
• Serves as an artifact of the architecture that is easier to read for visitors to the project than just the code by itself

Note that writing code to prototype the feature while working on the design may be very useful to help flesh out the approach.

A design document should be written as a markdown file in the design folder. You can follow the process outlined in the design template. You will see many examples of previous design documents in that folder. Submit a pull request for the design to be discussed and approved by the community before being merged into master, just like any other change to the repository.

An issue should be opened to track the work of authoring and completing the design document. This issue is in addition to the issue that is tracking the implementation of the feature. The design label should be assigned to the issue to denote it as such.

Create a Branch¶

From a console, create a new branch based on your fork and start working on it:

1
2
3
4
5
6

# Ensure all your remotes are up to date with the latest
git fetch --all

# Create a new branch that is based off upstream master.  Give it a simple, but descriptive name.
# Generally it will be two to three words separated by dashes and without numbers.
git checkout -b feature-name upstream/master

Now you are ready to make the changes and commit to your branch.

Updating Your Fork¶

During the development lifecycle, you will need to keep up-to-date with the latest upstream master. As others on the team push changes, you will need to rebase your commits on top of the latest. This avoids unnecessary merge commits and keeps the commit history clean.

Whenever you need to update your local repository, you never want to merge. You always will rebase. Otherwise you will end up with merge commits in the git history. If you have any modified files, you will first have to stash them (git stash save -u "<some description>").

1
2

git fetch --all
git rebase upstream/master

Rebasing is a very powerful feature of Git. You need to understand how it works or else you will risk losing your work. Read about it in the Git documentation, it will be well worth it. In a nutshell, rebasing does the following:

• "Unwinds" your local commits. Your local commits are removed temporarily from the history.
• The latest changes from upstream are added to the history
• Your local commits are re-applied one by one
• If there are merge conflicts, you will be prompted to fix them before continuing. Read the output closely. It will tell you how to complete the rebase.
• When done rebasing, you will see all of your commits in the history.

Submitting a Pull Request¶

Once you have implemented the feature or bug fix in your branch, you will open a Pull Request (PR) to the upstream Rook repository. Before opening the PR ensure you have added unit tests and all unit tests are passing. Please clean your commit history and rebase on the latest upstream changes.

See Unit Tests below for instructions on how to run unit tests.

In order to open a pull request (PR) it is required to be up to date with the latest changes upstream. If other commits are pushed upstream before your PR is merged, you will also need to rebase again before it will be merged.

Regression Testing¶

All pull requests must pass the unit and integration tests before they can be merged. These tests automatically run against every pull request as a part of Rook's continuous integration (CI) process. The results of these tests along with code reviews and other criteria determine whether your request will be accepted into the rook/rook repo.

Unit Tests¶

From the root of your local Rook repo execute the following to run all of the unit tests:

1

make test

Unit tests for individual packages can be run with the standard go test command. Before you open a PR, confirm that you have sufficient code coverage on the packages that you changed. View the coverage.html in a browser to inspect your new code.

1
2

go test -coverprofile=coverage.out
go tool cover -html=coverage.out -o coverage.html

Writing unit tests¶

There is no one-size-fits-all approach to unit testing, but we attempt to provide good tips for writing unit tests for Rook below.

Unit tests should help people reading and reviewing the code understand the intended behavior of the code.

Good unit tests start with easily testable code. Small chunks ("units") of code can be easily tested for every possible input. Higher-level code units that are built from smaller, already-tested units can more easily verify that the units are combined together correctly.

Common cases that may need tests:

• the feature is enabled
• the feature is disabled
• the feature is only partially enabled, for every possible way it can be partially enabled
• every error that can be encountered during execution of the feature
• the feature can be disabled (including partially) after it was enabled
• the feature can be modified (including partially) after it was enabled
• if there is a slice/array involved, test length = 0, length = 1, length = 3, length == max, length > max
• an input is not specified, for each input
• an input is specified incorrectly, for each input
• a resource the code relies on doesn't exist, for each dependency

Running the Integration Tests¶

Rook's upstream continuous integration (CI) tests will run integration tests against your changes automatically.

You do not need to run these tests locally, but you may if you like. For instructions on how to do so, follow the test instructions.

Commit structure¶

Rook maintainers value clear, lengthy and explanatory commit messages. So by default each of your commits must:

• be prefixed by the component it's affecting, if Ceph, then the title of the commit message should be ceph: my commit title. If not the commit-lint bot will complain.
• contain a commit message which explains the original issue and how it was fixed if a bug. If a feature it is a full description of the new functionality.
• refer to the issue it's closing, this is mandatory when fixing a bug
• have a sign-off, this is achieved by adding -s when committing so in practice run git commit -s. If not the DCO bot will complain. If you forgot to add the sign-off you can also amend a previous commit with the sign-off by running git commit --amend -s. If you've pushed your changes to GitHub already you'll need to force push your branch with git push -f.

Here is an example of an acceptable commit message:

1
2
3
4
5
6
7

component: commit title

This is the commit message, here I'm explaining, what the bug was along with its root cause.
Then I'm explaining how I fixed it.

Closes: https://github.com/rook/rook/issues/<NUMBER>
Signed-off-by: First Name Last Name <email address>

The component MUST be in the list checked by the CI.

Note: sometimes you will feel like there is not so much to say, for instance if you are fixing a typo in a text. In that case, it is acceptable to shorten the commit message. Also, you don't always need to close an issue, again for a very small fix.

You can read more about conventional commits.

Commit History¶

To prepare your branch to open a PR, you will need to have the minimal number of logical commits so we can maintain a clean commit history. Most commonly a PR will include a single commit where all changes are squashed, although sometimes there will be multiple logical commits.

1
2
3
4
5
6

# Inspect your commit history to determine if you need to squash commits
git log

# Rebase the commits and edit, squash, or even reorder them as you determine will keep the history clean.
# In this example, the last 5 commits will be opened in the git rebase tool.
git rebase -i HEAD~5

Once your commit history is clean, ensure you have based on the latest upstream before you open the PR.

Submitting¶

Go to the Rook github to open the PR. If you have pushed recently, you should see an obvious link to open the PR. If you have not pushed recently, go to the Pull Request tab and select your fork and branch for the PR.

After the PR is open, you can make changes simply by pushing new commits. Your PR will track the changes in your fork and update automatically.

Never open a pull request against a released branch (e.g. release-1.2) unless the content you are editing is gone from master and only exists in the released branch. By default, you should always open a pull request against master.

Backport a Fix to a Release Branch¶

The flow for getting a fix into a release branch is:

1. Open a PR to merge the changes to master following the process outlined above.
2. Add the backport label to that PR such as backport-release-1.7
3. After your PR is merged to master, the mergify bot will automatically open a PR with your commits backported to the release branch
4. If there are any conflicts you will need to resolve them by pulling the branch, resolving the conflicts and force push back the branch
5. After the CI is green, the bot will automatically merge the backport PR.